Absolute paths using REACT_APP_NODE_PATH instead of NODE_PATH

packages/react-scripts/config/env.js

@@ -57,7 +57,7 @@ dotenvFiles.forEach(dotenvFile => {
 // https://github.com/facebookincubator/create-react-app/issues/1023#issuecomment-265344421
 // We also resolve them to make sure all tools using them work consistently.
 const appDirectory = fs.realpathSync(process.cwd());
-process.env.NODE_PATH = (process.env.NODE_PATH || '')
+process.env.REACT_APP_NODE_PATH = (process.env.REACT_APP_NODE_PATH || '')
   .split(path.delimiter)
   .filter(folder => folder && !path.isAbsolute(folder))
   .map(folder => path.resolve(appDirectory, folder))

packages/react-scripts/config/webpack.config.dev.js

@@ -85,7 +85,7 @@ module.exports = {
     // https://github.com/facebookincubator/create-react-app/issues/253
     modules: ['node_modules', paths.appNodeModules].concat(
       // It is guaranteed to exist because we tweak it in `env.js`
-      process.env.NODE_PATH.split(path.delimiter).filter(Boolean)
+      process.env.REACT_APP_NODE_PATH.split(path.delimiter).filter(Boolean)
     ),
     // These are the reasonable defaults supported by the Node ecosystem.
     // We also include JSX as a common component filename extension to support

packages/react-scripts/config/webpack.config.prod.js

@@ -89,7 +89,7 @@ module.exports = {
     // https://github.com/facebookincubator/create-react-app/issues/253
     modules: ['node_modules', paths.appNodeModules].concat(
       // It is guaranteed to exist because we tweak it in `env.js`
-      process.env.NODE_PATH.split(path.delimiter).filter(Boolean)
+      process.env.REACT_APP_NODE_PATH.split(path.delimiter).filter(Boolean)
     ),
     // These are the reasonable defaults supported by the Node ecosystem.
     // We also include JSX as a common component filename extension to support

packages/react-scripts/scripts/utils/createJestConfig.js

@@ -11,7 +11,13 @@
 
 const fs = require('fs');
 const chalk = require('chalk');
+const path = require('path');
 const paths = require('../../config/paths');
+const getClientEnvironment = require('../../config/env');
+
+// Using development config publicUrl option when injecting environment variables.
+const publicUrl = '';
+getClientEnvironment(publicUrl);
 
 module.exports = (resolve, rootDir) => {
   // Use this instead of `paths.testsSetup` to avoid putting
@@ -41,6 +47,15 @@ module.exports = (resolve, rootDir) => {
     transformIgnorePatterns: [
       '[/\\\\]node_modules[/\\\\].+\\.(js|jsx|ts|tsx)$',
     ],
+    moduleDirectories: ['node_modules', paths.appNodeModules].concat(
+      // moduleDirectories uses a relative path
+      // Removing injected full path from REACT_APP_NODE_PATH (from env.js)
+      process.env.REACT_APP_NODE_PATH
+        .split(paths.appPath)
+        .join('')
+        .split(path.delimiter)
+        .filter(Boolean)
+    ),
     moduleNameMapper: {
       '^react-native$': 'react-native-web',
     },