This repository was archived by the owner on Jan 26, 2019. It is now read-only.
Merge remote-tracking branch from fb/master #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey Steven, firstly thanks for this! I've been having some thoughts about how/when to merge in the original src of this project, and I think as I'm making little changes here and there, and publishing them, I will only merge the FB src in once they release a new version of the package. This will allow us to have changes in master here, which can be published, without un-published changes from facebook. If you're interested in helping, this is an issue that you could fix? 😄 |
|
Sounds good, I will give it a go over the weekend. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to help up but am newb on this project.
Just did a merge from FB and ran the tests.