[1단계 Tomcat 구현하기] 폰드(권규택) 미션 제출합니다. #577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arachneee
approved these changes
Sep 7, 2024
Comment on lines
+54
to
+55
| String queryString = requestUri.substring(index + 1); | ||
| String[] queryParameters = queryString.split("&"); |
There was a problem hiding this comment.
QueryString 형식에 대한 예외 처리가 추가되면 좋을 것 같아요.
There was a problem hiding this comment.
= 확인을 통해 key와 value가 없는 상황을 검증하도록 수정하였습니다!
| if (Objects.equals(requestUri, "/")) { | ||
| return "Hello world!"; | ||
| } | ||
| if (requestUri.startsWith("/login?")) { |
There was a problem hiding this comment.
url에 /login만 입력했을 때는 로그인 페이지에 접속하지 못할 것 같습니다.
There was a problem hiding this comment.
url에 확장자가 없는 경우, html을 추가하도록 수정하였습니다.
다른 확장자에 대해서는 3단계에서 리팩터링 하겠습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 백호! BE 폰드입니다.🙇
웹 서버 구현이라기 보다는 미션 요구 사항만 최소한으로 지키게 되었네요..
따끔한 리뷰 해주십쇼..
감사합니다!