Skip to content

Limit predictive text override to Samsung keyboard #1027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

khaykov
Copy link
Contributor

@khaykov khaykov commented Jan 30, 2023

This PR restricts the fix introduced in #1024 to Samsung keyboards only. Since other keyboards actually work ok, this fix can limit their functionality.

I also changed the API level fix targeting to an open ended >= 33 since we do not know when or if it's going to be fixed.

Test (Using Samsung device running Android 13)

  1. Make sure default Samsung keyboard is installed on your device.
  2. Open the demo app and tap in the editor (this will initialize the Input Connection between keyboard and editor).
  3. Check logcat and confirm that you see the Overriding predictive text behavior on Samsung device with Samsung Keyboard with API 33 message.
  4. Install any other keyboard (eg. Gboard, Swift Keyboard)
  5. Open tap app and tap in the editor.
  6. Confirm that the log message from step 3 is not visible.

Voila.

@khaykov khaykov marked this pull request as ready for review January 30, 2023 22:21
@khaykov khaykov requested a review from nbradbury January 31, 2023 01:09
@nbradbury nbradbury self-assigned this Jan 31, 2023
Copy link
Contributor

@nbradbury nbradbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix is good! :shipit:

@nbradbury nbradbury merged commit 3aa28e0 into trunk Jan 31, 2023
@nbradbury nbradbury deleted the issue/limit-samsung-predictive-text-fix-to-samsung-keyboard branch January 31, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants