Feature/implement delete or update #1034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/implement-delete-or-update
…/implement-delete-or-update
…/implement-delete-or-update
…/implement-delete-or-update
Base automatically changed from
feature/implement-merging-of-placeholders
to
trunk
March 3, 2023 13:53
AmandaRiu
approved these changes
Mar 14, 2023
There was a problem hiding this comment.
Tested using the day one app in this PR and all works well! Checked the code here as well and it looks like the existing logic was moved to a method and tests were added and all look good 👍🏻 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
In this PR I'm adding a method that allows users to either remove or update a placeholder based on conditions. This is useful in cases like removing an image from a gallery. If the image is the last item in the gallery, we want to remove it instead of just updating the parameters. If it's not the last item, we'd probably want to remove the image params from the gallery.
Test
Review
@[USER_NAME]
Make sure strings will be translated:
strings.xmlas a part of the integration PR.