Remove unused code related to Avatar upload

[AdamGrzybkowski]

Description

This PR removes the FF that controlled the Quick Editor. With the flag gon,e we can remove more code that was there to select and upload avatars.

Testing instructions

The FF was enabled for some time so technically we should be good to go, but it won't hurt to make sure it all still works as intended. Having a good look at the removed code to make sure I haven't removed to much would be great as well :D

MeFragment

1. Test the Quick Editro avatar upload, selection etc.

SignupEpilogueFragment
This is where I would need some help. I remember having a way to enter this screen with the old magic link sign-up flow, but now with the OAuth, I'm not sure how to do it.

Based on what I was able to find, the app opens the LoginEpilogueActivity, not the SignupEpilogueActivity, after I create a new account.

[dangermattic]

	2 Warnings
⚠️	strings.xml files should only be updated on release branches, when the translations are downloaded by our automation.
⚠️	This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr21952-96f156f
	Commit	96f156f
	Direct Download	jetpack-prototype-build-pr21952-96f156f.apk

Note: Google Login is not supported on these builds.

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr21952-96f156f
	Commit	96f156f
	Direct Download	wordpress-prototype-build-pr21952-96f156f.apk

Note: Google Login is not supported on these builds.

[nbradbury]

This kind of thing always makes me happy :)

[nbradbury]

@AdamGrzybkowski I'm also not sure how SignupEpilogueActivity fits into the login flow, so I just added this at the end of WPMainActivity.onCreate to force it to appear:

ActivityLauncher.showSignupEpilogue(this, null, null, null, null, true);

To get it to work, though, I had to comment out the mUnifiedLoginTracker calls in SignupEpilogueFragment.

When the epilogue activity appeared my avatar was blank, but tapping to change it worked as expected.

I'm not sure if the blank avatar is due to how I'm forcing the activity to appear or if it's a genuine issue.

[AdamGrzybkowski]

Thanks!

I'm not sure if the blank avatar is due to how I'm forcing the activity to appear or if it's a genuine issue.

Quick Editor doesn't load the avatar, so it's unlikely to be related. I will take a look, though.

EDIT: The avatar doesn't load because you have to pass the URL via one of the params in the ActivityLauncher.showSignupEpilogue(). So now that you pass null, there's nothing to load.

[AdamGrzybkowski]

@nbradbury The other PR updating the Gravatar SDK to 2.5.0 was merged, so I've rebased on top of trunk and this is ready for review.

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[nbradbury]

Changes look good, merge when ready!