-
Notifications
You must be signed in to change notification settings - Fork 21
Llm integration POC #1028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Llm integration POC #1028
Conversation
…s allowed token count. Make conflicting libraries pydantic-ai and ag-ui optional; disabling agent route if not installed. Make search routes async and fix small bugs in query building.
CodSpeed Performance ReportMerging #1028 will not alter performanceComparing Summary
|
…hestrator-core into llm-integration
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1028 +/- ##
==========================================
- Coverage 85.14% 78.75% -6.40%
==========================================
Files 217 251 +34
Lines 10495 12387 +1892
Branches 1004 1214 +210
==========================================
+ Hits 8936 9755 +819
- Misses 1305 2372 +1067
- Partials 254 260 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dotenv run python main.py search semantic "Shop for an alligator store" | ||
... | ||
{ | ||
"path": "subscription.shop.shop_description", | ||
"value": "Kingswood reptiles shop" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should make the examples more generic (also the ones below), since this is specific for the WFO instance where we built the initial POC.
...migrations/versions/schema/2025-08-12_52b37b5b2714_search_index_model_for_llm_integration.py
Outdated
Show resolved
Hide resolved
orchestrator/search/docs/running_local_text_embedding_inference.md
Outdated
Show resolved
Hide resolved
orchestrator/search/filters/base.py
Outdated
FilterCondition = ( | ||
DateFilter # DATETIME | ||
| NumericFilter # INT/FLOAT | ||
| StringFilter # STRING TODO: convert to hybrid search |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to make a ticket for this TODO?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im thinking that maybe this stringfilter should be removed altogether, its already possible to do a hybrid search by passing a user query, passing something like the top 5 results back to the agent will probably yield better results.
For things like booleans/product blocks , we already have the equality filter. Matching on exact text by letting the agent fill in a string will probably not work well.
…ndpoints for autocompleting paths and UI compatible operators per field type for frontend rendering.
… settings and instructions.
…ption records in response, improve highlighting
…hestrator-core into llm-integration
…d substring highlighting
3840906
to
e9597e1
Compare
…ith just a field name and value type. Support component contains/not contains filters.
pydantic-ai
andag-ui-protocol
need
pydantic >= 2.10
and>=2.11.2
respectively, this breaks some of the unit tests