Skip to content

Conversation

timfdev
Copy link

@timfdev timfdev commented Aug 12, 2025

pydantic-ai and ag-ui-protocol

need pydantic >= 2.10 and >=2.11.2 respectively, this breaks some of the unit tests

…s allowed token count. Make conflicting libraries pydantic-ai and ag-ui optional; disabling agent route if not installed. Make search routes async and fix small bugs in query building.
Copy link

codspeed-hq bot commented Aug 16, 2025

CodSpeed Performance Report

Merging #1028 will not alter performance

Comparing llm-integration (c35a073) with main (8a2b890)

Summary

✅ 13 untouched

Copy link

codecov bot commented Aug 18, 2025

Codecov Report

❌ Patch coverage is 43.57218% with 1071 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.75%. Comparing base (8a2b890) to head (c35a073).

Files with missing lines Patch % Lines
orchestrator/search/indexing/indexer.py 22.94% 131 Missing ⚠️
orchestrator/search/retrieval/retriever.py 33.11% 101 Missing ⚠️
orchestrator/search/indexing/traverse.py 32.00% 85 Missing ⚠️
orchestrator/api/api_v1/endpoints/search.py 32.03% 70 Missing ⚠️
orchestrator/cli/speedtest.py 26.74% 62 Missing and 1 partial ⚠️
orchestrator/search/filters/base.py 42.05% 62 Missing ⚠️
orchestrator/cli/resize_embedding.py 21.21% 51 Missing and 1 partial ⚠️
orchestrator/search/retrieval/utils.py 22.72% 51 Missing ⚠️
orchestrator/search/core/types.py 65.03% 50 Missing ⚠️
orchestrator/search/retrieval/validation.py 25.00% 45 Missing ⚠️
... and 18 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1028      +/-   ##
==========================================
- Coverage   85.14%   78.75%   -6.40%     
==========================================
  Files         217      251      +34     
  Lines       10495    12387    +1892     
  Branches     1004     1214     +210     
==========================================
+ Hits         8936     9755     +819     
- Misses       1305     2372    +1067     
- Partials      254      260       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment on lines +46 to +51
dotenv run python main.py search semantic "Shop for an alligator store"
...
{
"path": "subscription.shop.shop_description",
"value": "Kingswood reptiles shop"
},

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make the examples more generic (also the ones below), since this is specific for the WFO instance where we built the initial POC.

FilterCondition = (
DateFilter # DATETIME
| NumericFilter # INT/FLOAT
| StringFilter # STRING TODO: convert to hybrid search

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to make a ticket for this TODO?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im thinking that maybe this stringfilter should be removed altogether, its already possible to do a hybrid search by passing a user query, passing something like the top 5 results back to the agent will probably yield better results.

For things like booleans/product blocks , we already have the equality filter. Matching on exact text by letting the agent fill in a string will probably not work well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants