PHPStan level 9 #453
Open
PHPStan level 9 #453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
commented
May 18, 2025
| @@ -875,7 +904,7 @@ protected function get_item_list() { | |||
|
|
|||
| if ( isset( $plugin_update_info->requires ) && version_compare( $wp_version, $requires, '>=' ) ) { | |||
| $reason = "This update requires WordPress version $plugin_update_info->requires, but the version installed is $wp_version."; | |||
| } elseif ( ! isset( $update_info['package'] ) ) { | |||
| } elseif ( ! isset( $plugin_update_info->package ) ) { | |||
There was a problem hiding this comment.
$update_info does not exist at this point.
Introduced in #451
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly doc block improvements, but also fixes a regression from #451