Switch to Vite #41
Merged
Switch to Vite #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan412
reviewed
Feb 12, 2025
There was a problem hiding this comment.
I pulled it down and verified that it worked, but I am leaving it up to @lizlooney to approve because I don't know what drove the original choice of CRA.
|
I checked with both @lizlooney and @bhjelstrom and they are fine with moving to Vite, so I'll go ahead and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #40
Rationale
Create React App is legacy software that has been unmaintained for years, and is deprecated by Meta. Vite has quickly become the new standard for standalone React apps like this. It provides modern, maintained, and widely-used tooling to replace Create React App.
This PR replaces CRA with Vite. It also fixes/replaces the testing harness (it was broken previously). These changes should be self-explanatory for the most part, but feel free to ask if anything isn't.
It also adds testing and building in CI. I would have added this as a separate PR, but testing was previously broken and setup is slightly different with this PR.