This repository was archived by the owner on Oct 24, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A WIP attempt to get operations like
*
and+
working onDatasetNode
objects.Idea is to copy the pattern used to add these operators to
xarray.Dataset
, whereDataset
inherits fromDatasetArithmetic
.DatasetArithmetic
itself inherits from about 5 different Mixin classes, which I don't particularly want to regenerate, especially asDatasetOpsMixin
is generated by templating in xarray. Here we instead just want to take the methods defined onDatasetArithmetic
and decorate them withmap_over_subtree
, to get aDataTreeArithmetic
object to inherit from.Problem is at the moment I'm getting errors like this:
I don't understand why this is happening because
__mul__
and__rmul__
are definitely defined on thedt
objects. (Could it be because those methods get defined only once the object instance has been created, and not when the class is defined?)