Skip to content

Refactor process execution during a simulation #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Sep 26, 2019

Conversation

benbovy
Copy link
Member

@benbovy benbovy commented Sep 24, 2019

Closes #40.

Also provides more flexibility for #52.

This refactoring is also a step towards making the framework less invasive. Ideally, a process class could be also instantiated and used independently of any model. This is important for testing purposes! Currently it is supported for "runtime" methods but we need a solution for __init__ too.

TODO:

  • set runtime context dictionary and use it in xarray driver
  • remove Model.initialize(), Model.run_step() etc (no depreciation)
  • add tests where it is needed
  • update docs
  • update what's new

@benbovy benbovy merged commit c5458be into master Sep 26, 2019
@benbovy benbovy mentioned this pull request Sep 29, 2019
5 tasks
@benbovy benbovy deleted the process-runtime-refactor branch December 11, 2019 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow flexible signatures for simulation runtime methods in process classes
1 participant