Skip to content

Conversation

scottyhq
Copy link
Contributor

Supercedes #597

Copy link

vercel bot commented Aug 11, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
xarray-dev Ready Ready Preview Comment Sep 2, 2025 8:32pm

Copy link

netlify bot commented Aug 11, 2025

Deploy Preview for xarraydev ready!

Name Link
🔨 Latest commit bdef441
🔍 Latest deploy log https://app.netlify.com/projects/xarraydev/deploys/68b753ea548f880008d12be1
😎 Deploy Preview https://deploy-preview-795--xarraydev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Member

@keewis keewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, Scott, that was a nice read.

I didn't check how this looks, but from the markdown at least this looks good to me in general. I do have a few comments on the details, though.

scottyhq and others added 2 commits August 25, 2025 13:51
Co-authored-by: Deepak Cherian <[email protected]>
Co-authored-by: Deepak Cherian <[email protected]>
@scottyhq
Copy link
Contributor Author

I left a few pretty minor suggestions. Let's get this out next week!

Thanks, publishing this week sounds good to me! I added your suggestions and went over one more time with a few tweaks. @benbovy do you have time this week to have a look?

Copy link
Member

@benbovy benbovy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @scottyhq for putting this together! And sorry for the late review.

Overall this looks great! I added a few comments, mostly nit picking.

Comment on lines 5 to 8
- name: Benoît Bovy
github: benbovy
- name: Scott Henderson
github: scottyhq
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scottyhq since you authored this blog post I think it would make sense to add you as 1st author here, or at least add something that gives you credit for authoring this post.

I'm thinking of authoring a follow-up technical blog post on how to customize Xarray's behavior via indexes for common operations such as assigning, indexing and alignment (with flowcharts illustrating the logic of Xarray internals and how the index API is called).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, either way is fine by me. want to make sure you're recognized as leading the effort overall!

@scottyhq
Copy link
Contributor Author

scottyhq commented Sep 2, 2025

Thanks for the review @benbovy I've incorporated all your feedback. I'm going to go ahead and merge it in, thanks again everyone for helping with this!

@scottyhq scottyhq merged commit f384aac into main Sep 2, 2025
7 checks passed
@scottyhq scottyhq deleted the flexible-indexes2 branch September 2, 2025 20:35
@keewis
Copy link
Member

keewis commented Sep 2, 2025

the only thing we forgot to do is update the blog post release date: right now it says "23 days ago"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants