Skip to content

Converted XTIME from datetime64 to timedelta, in line with its description #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 20, 2022
Merged

Converted XTIME from datetime64 to timedelta, in line with its description #71

merged 5 commits into from
Apr 20, 2022

Conversation

lpilz
Copy link
Collaborator

@lpilz lpilz commented Apr 13, 2022 •
edited
Loading

Change Summary

Now casting XTIME to timedelta64 from simulation start like the description states. Unfortunately, xarray can't handle timedelta64[m] datetypes, this would have been ideal.

I'll look into adding some tests

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI

@lpilz lpilz marked this pull request as ready for review April 14, 2022 13:15
dcherian
dcherian reviewed Apr 14, 2022
View reviewed changes
@lpilz lpilz requested a review from dcherian April 19, 2022 17:32
dcherian
dcherian reviewed Apr 19, 2022
View reviewed changes
@lpilz lpilz merged commit 89c2d37 into xarray-contrib:main Apr 20, 2022
@lpilz lpilz deleted the fix_xtime branch April 20, 2022 09:33
@andersy005 andersy005 added the enhancement New feature or request label Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcherian dcherian dcherian approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lpilz @dcherian @andersy005