Attestation support for amd-sev #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TSnake41
reviewed
Oct 3, 2025
tools/include/libxl.h
Outdated
| /* | ||
| * Used to retrieve for a domain using coco | ||
| */ | ||
| int libxl_domain_attestation(libxl_ctx *ctx, uint32_t domain_id, FILE *file, bool is_mmonce_file, char *mmonce); |
There was a problem hiding this comment.
domain_id -> domid
I don't think exposing FILE * in the ABI is wise, if streaming something is absolutely necessary, a fd would be preferable.
xen/include/public/hvm/coco.h
Outdated
| DEFINE_XEN_GUEST_HANDLE(coco_prepare_initial_mem_t); | ||
|
|
||
| struct coco_attestation_report { | ||
| uint32_t handle; /* IN */ |
There was a problem hiding this comment.
this should be domid_t domid; instead
| void* address; /* In */ | ||
| uint8_t mnonce[16]; /* In */ | ||
| uint32_t len; /* In/Out */ | ||
| }; |
There was a problem hiding this comment.
that's (almost) the same struct as the previous one
tools/libs/light/libxl_domain.c
Outdated
| } | ||
|
|
||
| report.handle = domain_id; | ||
| report.address = &result; |
There was a problem hiding this comment.
userland virtual addresses (e.g pointers) in hypercalls is incorrect even though it often works (but can randomly fail depending on how the process memory is managed)
xen/common/coco.c
Outdated
| char resp[208]; | ||
|
|
||
| d = get_domain_by_id(report.handle); | ||
| rc = d->coco_ops->domain_attestation_report(d, report, resp); |
There was a problem hiding this comment.
you need to check that :
- domain actually exists (d != NULL); report -ENOENT otherwise
- domain is confidential computing (is_coco_domain); report -EINVAL otherwise
d->coco_ops&&d->coco_ops->domain_attestation_report(so that platforms that don't support it don't cause NULL dereference); report -EOPNOTSUPP (or -ENODEV?) otherwise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.