Skip to content

feat(test): playwright configuration and e2e tests, fix cdk tree comp… #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 14, 2023

Conversation

jzolnowski
Copy link

  • Playwright configuration
  • Adding e2e tests for Angular and AngularJS Material components

@jzolnowski jzolnowski changed the base branch from feature/migration-to-latest-dependency-versions to master February 2, 2023 10:56
@jzolnowski jzolnowski requested a review from gkalpak February 8, 2023 20:47
…ub link test, replaced click handlers in Page Objects by direct click() method invokes, simplify shouldRender method in cdk-tree component, add test packackage.json script
@jzolnowski
Copy link
Author

@gkalpak PR ready for another round of review

Copy link

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple tiny comments.
Otherwise lgtm 👍

@jzolnowski
Copy link
Author

@gkalpak PR ready for final review

@Splaktar Splaktar merged commit a935da5 into master Mar 14, 2023
@Splaktar Splaktar deleted the feature/tests-improvement branch March 14, 2023 16:52
jzolnowski added a commit that referenced this pull request Apr 3, 2023
- fix cdk tree component
- fix lint issues
- add .angular folder to .gitignore
- remove templates from source control
- add templates to gitignore
- add console.log error test
- add tab content visibility test
- replace waitForTimeout with waitForLoadState
- improve playwright configuration
- change assertion in a GitHub link test
- replace click handlers in Page Objects with direct `click()` method invocations
- simplify `shouldRender` method in `cdk-tree` component
- add test packackage.json script
jzolnowski added a commit that referenced this pull request Apr 3, 2023
- fix cdk tree component
- fix lint issues
- add .angular folder to .gitignore
- remove templates from source control
- add templates to gitignore
- add console.log error test
- add tab content visibility test
- replace waitForTimeout with waitForLoadState
- improve playwright configuration
- change assertion in a GitHub link test
- replace click handlers in Page Objects with direct `click()` method invocations
- simplify `shouldRender` method in `cdk-tree` component
- add test packackage.json script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants