forked from Splaktar/angularjs-angular-material-hybrid-demo
-
Notifications
You must be signed in to change notification settings - Fork 0
feat(test): playwright configuration and e2e tests, fix cdk tree comp… #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzolnowski
commented
Feb 2, 2023
- Playwright configuration
- Adding e2e tests for Angular and AngularJS Material components
…ror test, add tab cotnent visibility test, remplate waitForTimeout by waitForLoadState, improve playwright configuration
gkalpak
requested changes
Mar 3, 2023
…ub link test, replaced click handlers in Page Objects by direct click() method invokes, simplify shouldRender method in cdk-tree component, add test packackage.json script
@gkalpak PR ready for another round of review |
gkalpak
approved these changes
Mar 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple tiny comments.
Otherwise lgtm 👍
@gkalpak PR ready for final review |
gkalpak
approved these changes
Mar 9, 2023
jzolnowski
added a commit
that referenced
this pull request
Apr 3, 2023
- fix cdk tree component - fix lint issues - add .angular folder to .gitignore - remove templates from source control - add templates to gitignore - add console.log error test - add tab content visibility test - replace waitForTimeout with waitForLoadState - improve playwright configuration - change assertion in a GitHub link test - replace click handlers in Page Objects with direct `click()` method invocations - simplify `shouldRender` method in `cdk-tree` component - add test packackage.json script
jzolnowski
added a commit
that referenced
this pull request
Apr 3, 2023
- fix cdk tree component - fix lint issues - add .angular folder to .gitignore - remove templates from source control - add templates to gitignore - add console.log error test - add tab content visibility test - replace waitForTimeout with waitForLoadState - improve playwright configuration - change assertion in a GitHub link test - replace click handlers in Page Objects with direct `click()` method invocations - simplify `shouldRender` method in `cdk-tree` component - add test packackage.json script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.