Remove reference to traceback object in _TestInfo.err Issue #105 #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self.err = err | ||
| self.test_exception_name = None | ||
| self.test_exception_message = None | ||
| if self.outcome != _TestInfo.SUCCESS: |
|
Please add a testcase checking for those references; e.g. using |
|
obsolete - see #108 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully a correct fix this time.
Issue #105: I still think it is a bug to be fixed. Thanks for the hit with the traceback object, dnozay. A reference to the traceback object is hold in _TestInfo.err. Remove this reference to get the wanted destruction behavior.