Fix find_package(xsimd) for xtl enabled xsimd, reloaded #875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR xtensor-stack#788 fixes xtl lookup by adding the corresponding find_dependency call. However, there are still two issues remaining: - If xtl is not found, the INTERFACE_LINK_LIBRARIES property will make CMake interpret "xtl" as a .lib, pass it as a -l flag, and cause the build to fail. - If xtl is used, the required definition XSIMD_ENABLE_XTL_COMPLEX=1 is never passsed to downstream consumers. This commit fixes both issues, ensuring that if xtl was required at compile time, the Config module with not load unless xtl is also found. Fixes xtensor-stack#869
|
@JohanMabille It should be noted that this commit (along with #788) has to be cherry-picked to 8.x for Debian to stop breaking Krita builds. |
|
Awesome! Thanks for this fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #788 fixes xtl lookup by adding the corresponding find_dependency call. However, there are still two issues remaining:
If xtl is not found, the INTERFACE_LINK_LIBRARIES property will make CMake interpret "xtl" as a .lib, pass it as a -l flag, and cause the build to fail.
If xtl is used, the required definition XSIMD_ENABLE_XTL_COMPLEX=1 is never passsed to downstream consumers.
This commit fixes both issues, ensuring that if xtl was required at compile time, the Config module with not load unless xtl is also found.
Fixes #869