Skip to content

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Sep 15, 2016

build/xterm.js should be used when require is used when installed via npm.

build/xterm.js should be used when require is used when installed via npm.
@parisk
Copy link
Contributor

parisk commented Sep 16, 2016

Could you please run npm build into the postinstall script? Otherwise it might load a wrong version of the library.

@Tyriar
Copy link
Member Author

Tyriar commented Sep 16, 2016

@parisk does postinstall run when it's installed via npm? If so babel and the like would need to be dependencies, not devDependencies. It would also mean it rebuilds what we push as a release in ./build on install.

@Tyriar
Copy link
Member Author

Tyriar commented Sep 16, 2016

We want to check in ./build/ when we publish right?

@parisk
Copy link
Contributor

parisk commented Sep 16, 2016

Yes, I think eventually the postinstall thing is not a good idea.

Also, yes we will have to check in ./build/ when we publish, in order to make this work out of the box for everyone, plain browser to amd, commonjs and node.

@parisk
Copy link
Contributor

parisk commented Sep 16, 2016

Please give me a little bit more time here to think about any other possible solutions.

@Tyriar
Copy link
Member Author

Tyriar commented Oct 1, 2016

@parisk pretty sure we need this if we want people who use npm to use the version in build/ (the most compatible version).

@parisk parisk merged commit 3e77db8 into xtermjs:master Oct 3, 2016
@parisk
Copy link
Contributor

parisk commented Oct 3, 2016

This was reverted in 68906b5#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R9 as people need to fetch from dist. build is ignored by Git and is there for development purposes.

@Tyriar Tyriar deleted the set_package_main branch February 3, 2017 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants