Skip to content

feat: add relation resolver param to order callback #3232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025
Merged

feat: add relation resolver param to order callback #3232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/QueryDataTable.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -691,11 +691,10 @@ protected function defaultOrdering(): void
})
->reject(fn ($orderable) => $this->isBlacklisted($orderable['name']) && ! $this->hasOrderColumn($orderable['name']))
->each(function ($orderable) {
$column = $this->resolveRelationColumn($orderable['name']);

if ($this->hasOrderColumn($orderable['name'])) {
$this->applyOrderColumn($column, $orderable);
$this->applyOrderColumn($orderable);
} else {
$column = $this->resolveRelationColumn($orderable['name']);
$nullsLastSql = $this->getNullsLastSql($column, $orderable['direction']);
$normalSql = $this->wrap($column).' '.$orderable['direction'];
$sql = $this->nullsLast ? $nullsLastSql : $normalSql;
Expand All @@ -715,15 +714,15 @@ protected function hasOrderColumn(string $column): bool
/**
* Apply orderColumn custom query.
*/
protected function applyOrderColumn(string $column, array $orderable): void
protected function applyOrderColumn(array $orderable): void
{
$sql = $this->columnDef['order'][$orderable['name']]['sql'];
if ($sql === false) {
return;
}

if (is_callable($sql)) {
call_user_func($sql, $this->query, $orderable['direction'], $column);
call_user_func($sql, $this->query, $orderable['direction'], fn ($column) => $this->resolveRelationColumn($column));
} else {
$sql = str_replace('$1', $orderable['direction'], (string) $sql);
$bindings = $this->columnDef['order'][$orderable['name']]['bindings'];
Expand Down
4 changes: 2 additions & 2 deletions tests/Integration/CustomOrderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,8 @@ protected function setUp(): void
parent::setUp();

$this->app['router']->get('/relations/belongsTo', fn (DataTables $datatables) => $datatables->eloquent(Post::with('user')->select('posts.*'))
->orderColumn('user.id', function ($query, $order, $column) {
$query->orderBy($column, $order == 'desc' ? 'asc' : 'desc');
->orderColumn('user.id', function ($query, $order, $resolver) {
$query->orderBy($resolver('user.id'), $order == 'desc' ? 'asc' : 'desc');
})
->toJson());
}
Expand Down
Loading