fix(dropdownToggle): Dropdown not repositioned when window resized #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -90,6 +90,16 @@ angular.module('mm.foundation.dropdownToggle', [ 'mm.foundation.position', 'mm.f | |||
| } | |||
| }; | |||
| $document.on('click', closeMenu); | |||
|
|
|||
| angular.element($window).bind('resize', function() { | |||
There was a problem hiding this comment.
Any reason why you use bind() here instead of on() like the rest of the event listeners?
There was a problem hiding this comment.
We need to clean up this event listener on $destroy. See https://code.angularjs.org/1.4.7/docs/guide/directive#creating-a-directive-that-manipulates-the-dom
There was a problem hiding this comment.
No particular reason for bind(), changing.
Also, added cleanup on $destroy as suggested.
|
Thanks for sending this in, @lerio. In addition to my previous comments can you please try to add some tests for this behavior? |
|
Did the required changes, but I didn't add any test yet. Can you suggest me a way to test $window resize on jasmine? |
|
Bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #258.
When window is resized, the open dropdown is not correctly repositioned below its toggle. Now the behaviour is correct either when the dropdown is left or right aligned.
Before:
After:
