Skip to content

ci: use latest stable version of actions #4954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 13, 2022
Merged

ci: use latest stable version of actions #4954

merged 3 commits into from
Oct 13, 2022

Conversation

jj811208
Copy link
Contributor

@jj811208 jj811208 commented Oct 11, 2022 •
edited
Loading

What's the problem this PR addresses?

GitHub announced that GitHub Action will no longer support node12 in the summer of 2023
https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/

So most of Yarn's GitHub Actions have warnings

I looked at all the Action we use, here are the actions that use node 12

  • actions/cache@v2
  • actions/checkout@v2
  • actions/upload-artifact@v2
  • actions/download-artifact@v2

but I don't know why only actions/cache@v2 has a warning 🧐.

image

...

How did you fix it?

  • update actions/cache from v2 to v3
  • update actions/checkout from v2 to v3
  • update actions/upload-artifact from v2 to v3
  • update actions/download-artifact from v2 to v3
  • update actions/stale from v5 to v6
  • change the workflows that use @master to use a tagged version

...

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@merceyz
Copy link
Member

merceyz commented Oct 11, 2022

I only updated action/cache from v2 to v3

Might as well update them all in one go so we don't have to do it later.

@jj811208
Copy link
Contributor Author

jj811208 commented Oct 11, 2022 •
edited
Loading

There are four E2E broken, but all were broken before this PR

  • E2E Snowpack
    Seems to be an occasional error, however, as far as I know, snowpack is no longer actively maintained, so I personally prefer not to test this https://www.snowpack.dev/
    image

  • E2E PnP Angular
    This is not a yarn problem, It's a problem with rxjs 7.5.7

  • E2E Storybook
    Probably not a yarn problem, it suddenly broke one day

  • E2E NM Babel Install
    It's been broken for almost a month, I guess it's probably a yarn problem, because I went to test the August version of yarn in my fork and it passed, but I didn't find the reason

@jj811208 jj811208 marked this pull request as ready for review October 11, 2022 15:48
@jj811208 jj811208 requested a review from arcanis as a code owner October 11, 2022 15:48
@merceyz
Copy link
Member

merceyz commented Oct 11, 2022

E2E Snowpack
Seems to be an occasional error, however, as far as I know, snowpack is no longer actively maintained so I personally prefer not to test this

Agreed, would you like to remove it in a follow-up PR?

E2E Storybook
Probably not a yarn problem, it suddenly broke one day

Will be fixed in the next Storybook release (storybookjs/storybook#19366)

E2E NM Babel Install
It's been broken for almost a month, I guess it's probably a yarn problem

They have some custom plugins that aren't compatible with Yarn v4 yet.

merceyz
merceyz requested changes Oct 11, 2022
View reviewed changes
Copy link
Member

@merceyz merceyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also change the workflows that use @master to use a tagged version?

@jj811208 jj811208 force-pushed the ci/fix-e2e-warning branch 2 times, most recently from b498812 to 8f2e8b9 Compare October 11, 2022 19:11
@jj811208
Copy link
Contributor Author

jj811208 commented Oct 11, 2022 •
edited
Loading

Agreed, would you like to remove it in a follow-up PR?

Yes~~ 😃

Will be fixed in the next Storybook release (storybookjs/storybook#19366)

Looks great!

Could you also change the workflows that use @master to use a tagged version?

OK, I made changes in this commit e0427c0

but after I modified package-workflow.yml, it triggered https://github.com/yarnpkg/berry/actions/runs/3229402471 and it failed.

it seems that it is explicitly defined to use node 12, but the Nullish coalescing operator can only be used on node 14, so I upgraded it to node 16 8f2e8b9 ,but it still errors 😨,

I'm not sure if this e2e is no longer used, and it not caused by this PR either, so I decided not to pay attention to it🙈 .

@merceyz
Copy link
Member

merceyz commented Oct 11, 2022 •
edited
Loading

Yeah, in the future we should remove that workflow (revert #379) as we don't publish Debian packages anymore but lets leave that for another PR and just revert any changes to that workflow for now.

@merceyz merceyz changed the title ci: clear warning messages about GitHub Action will no longer support node12 ci: use latest and stable version of actions Oct 11, 2022
@merceyz merceyz changed the title ci: use latest and stable version of actions ci: use latest stable version of actions Oct 11, 2022
@jj811208
Copy link
Contributor Author

jj811208 commented Oct 12, 2022 •
edited
Loading

[...] just revert any changes to that workflow for now.

OK, mission complete✌

I noticed a change in the PR title, so I updated "actions/stale" to v6, although v5 was using node 16, but upgrading to the latest version is more in line with what the PR title describes

45a84a5

https://github.com/actions/stale/releases/tag/v6.0.0

merceyz
merceyz previously approved these changes Oct 12, 2022
View reviewed changes
Copy link
Member

@merceyz merceyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you!

@jj811208 jj811208 mentioned this pull request Oct 12, 2022
Closed
3 tasks
@arcanis arcanis merged commit 18ea1fe into yarnpkg:master Oct 13, 2022
@jj811208 jj811208 mentioned this pull request Oct 13, 2022
Merged
3 tasks
@jj811208 jj811208 deleted the ci/fix-e2e-warning branch October 13, 2022 18:22
merceyz pushed a commit that referenced this pull request Apr 24, 2023
@jj811208 @merceyz
ci: use latest stable version of actions (#4954)
92906b4 
* ci: clear warning messages about `GitHub Action will no longer support node12`

* ci: change the workflows that use @master to use a tagged version

* ci: use `actions/stale@v6`
@legobeat legobeat mentioned this pull request Jul 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merceyz merceyz merceyz left review comments

@arcanis arcanis Awaiting requested review from arcanis arcanis is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jj811208 @merceyz @arcanis