Skip to content

Fix release compilation #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Conversation

bgotink
Copy link
Member

@bgotink bgotink commented Jan 23, 2020

  • Make necessary changes to allow declaration generation to succeed
  • Stop emitting declarations in webpack builds, because those land in the sources folders
  • Change the build command of pnp to make it work (running build:compile used to delete the output of build:pnp)

@bgotink bgotink requested a review from arcanis January 23, 2020 14:58
@arcanis
Copy link
Member

arcanis commented Jan 23, 2020

Thanks for this! I took a look myself to see whether it could be fixed without having to add the explicit annotation but that went nowhere. Seems like it's a TS issue 🤷‍♀️

Ignore the version check, I'll be releasing all packages anyway 👍

@bgotink
Copy link
Member Author

bgotink commented Jan 23, 2020

Ah I'd already pushed the version check, whoopsie.

Yeah, it seems like enabling declarations makes typescript a bit more strict on these types. I don't fully understand why this error is present though, because typescript could infer the type quite easily to import('clipanion').Usage in this case.

@arcanis
Copy link
Member

arcanis commented Jan 24, 2020

Manually merged in master, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants