Fix: Progress bar continue to update after footer #4084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Summary** Fixes #4023. There was nothing preventing the console reporter from having more than one progress bars, or keep updating and rendering its progress bar after it was finished or the reporter was "done". This patch stores the active progress bar, and stops it before `footer` is printed out. Also makes sure the progress bar itself ignores any updates once it stops. **Test plan** One, weak, existing test with updated snapshot. Manual steps: - Run `yarn install express` - Observe that your console is properly cleared after `yarn` finishes and the last thing you see is the "Done in X.YZs." message and not a corrupted progress bar.
cpojer
reviewed
Aug 4, 2017
| chars: [string, string]; | ||
| delay: number; | ||
| id: ?number; | ||
| _callback: ?Function; |
There was a problem hiding this comment.
Can you properly type this callback function?
mjesun
reviewed
Aug 4, 2017
| if (!this.id) { | ||
| clearTimeout(this.id); | ||
| clearLine(this.stdout); | ||
| this.id = null; |
There was a problem hiding this comment.
If !this.id then the timeout is cleared?
mjesun
approved these changes
Aug 4, 2017
kaylie-alexa
pushed a commit
to kaylie-alexa/yarn
that referenced
this pull request
Aug 7, 2017
…)" This reverts commit 280b6eb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4023. There was nothing preventing the console reporter from
having more than one progress bars, or keep updating and rendering
its progress bar after it was finished or the reporter was "done".
This patch stores the active progress bar, and stops it before
footeris printed out. Also makes sure the progress bar itselfignores any updates once it stops.
Test plan
One, weak, existing test with updated snapshot. Manual steps:
yarn install expressyarnfinishes and the last thing you see is the "Done in X.YZs."
message and not a corrupted progress bar.