fix(cli): Use correct directory for upgrade-interactive

[jungomi]

Summary

upgrade-interactive was updating the package.json in the current directory (where Yarn was run) instead of where the upgrades were made. The most notable occurrence of this was global upgrade-interactive, but it also happened by using the --cwd option.

When the location was not a workspace, it resolved to the current directory instead of using the previously configured one. Additionally, config.cwd was changed without being cleaned up, so it contained the last processed workspace, which affected anything that used it afterwards (e.g. symlinking binaries).

Fixes #4728
Fixes #4952
Fixes #4922

Test plan

Install any package globally, then upgrade it interactively without being in the global directory. (or with --cwd). The binary of the package that is being upgraded was symlinked again, but all other symlinks were removed.

Before

# Outdated version of `serve`, `prettier` for an extra binary
$ ~/some-dir ➜  yarn global add prettier [email protected]
yarn global v1.4.1
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
[4/4] Building fresh packages...
success Installed "[email protected]" with binaries:
      - prettier
success Installed "[email protected]" with binaries:
      - serve
Done in 1.65s.

# Prettier binary is available
$ ~/some-dir ➜  prettier --version
1.10.2

$ ~/some-dir ➜  cat package.json
cat: package.json: No such file or directory

$ ~/some-dir ➜  cat $(yarn global dir)/package.json
{
  "dependencies": {
    "prettier": "^1.10.2",
    "serve": "6.0.0"
  }
}

# Upgrade `serve` to the latest version
$ ~/some-dir ➜  yarn global upgrade-interactive --latest
yarn global v1.4.1
info Color legend :
 "<red>"    : Major Update backward-incompatible updates
 "<yellow>" : Minor Update backward-compatible features
 "<green>"  : Patch Update backward-compatible bug fixes
? Choose which packages to update.
? Choose which packages to update. [email protected]
info Installing "dependencies"...
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
[4/4] Building fresh packages...
success Saved lockfile.
success Saved 35 new dependencies.
├─ @zeit/[email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
└─ [email protected]
Done in 3.69s.

# Prettier binary no longer exists
$ ~/some-dir ➜  prettier --version
-bash: prettier: command not found

# Suddenly, there is a package.json in the current directory
$ ~/some-dir ➜  cat package.json
{
  "dependencies": {
    "serve": "6.4.9"
  }
}

# Global package.json did not update
$ ~/some-dir ➜  cat $(yarn global dir)/package.json
warning package.json: No license field
{
  "dependencies": {
    "prettier": "^1.10.2",
    "serve": "6.0.0"
  }
}

After

# Outdated version of `serve`, `prettier` for an extra binary
$ ~/some-dir ➜  yarn global add prettier [email protected]
yarn global v1.4.1
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
[4/4] Building fresh packages...
success Installed "[email protected]" with binaries:
      - prettier
success Installed "[email protected]" with binaries:
      - serve
Done in 1.92s.

# Prettier binary is available
$ ~/some-dir ➜  prettier --version
1.10.2

$ ~/some-dir ➜  cat package.json
cat: package.json: No such file or directory

$ ~/some-dir ➜  cat $(yarn global dir)/package.json
{
  "dependencies": {
    "prettier": "^1.10.2",
    "serve": "6.0.0"
  }
}

# Upgrade `serve` to the latest version
$ ~/some-dir ➜  yarn global upgrade-interactive --latest
yarn global v1.4.1
info Color legend :
 "<red>"    : Major Update backward-incompatible updates
 "<yellow>" : Minor Update backward-compatible features
 "<green>"  : Patch Update backward-compatible bug fixes
? Choose which packages to update.
? Choose which packages to update. [email protected]
info Installing "dependencies"...
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
[4/4] Building fresh packages...
success Saved lockfile.
success Saved 34 new dependencies.
├─ @zeit/[email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
└─ [email protected]
Done in 3.00s.

# Prettier is still available
$ ~/some-dir ➜  prettier --version
1.10.2

$ ~/some-dir ➜  cat package.json
cat: package.json: No such file or directory

# Global package.json was correctly updated
$ ~/some-dir ➜  cat $(yarn global dir)/package.json
{
  "dependencies": {
    "prettier": "^1.10.2",
    "serve": "6.4.9"
  }
}

[TimvdLippe]

Cool, thanks for fixing my issue #4728 🎉

[arcanis]

Thanks!