Skip to content

Stop copying .bin folders #6628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 3, 2018
Merged

Stop copying .bin folders #6628

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24cd7e6
Stops copying the .bin folder from the cache
arcanis Nov 3, 2018
4b0924e
Adds a test
arcanis Nov 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions __tests__/commands/install/integration.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,11 @@ async function mockConstants(base: Config, mocks: Object, cb: (config: Config) =
beforeEach(request.__resetAuthedRequests);
afterEach(request.__resetAuthedRequests);

test('install should not copy the .bin folders from the cache', () =>
runInstall({}, 'install-no-bin', async config => {
expect(await fs.exists(`${config.cwd}/node_modules/is-pnp/.bin`)).toEqual(false);
}));

test('install should not hoist packages above their peer dependencies', () =>
runInstall({}, 'install-should-not-hoist-through-peer-deps', async config => {
expect(await fs.exists(`${config.cwd}/node_modules/a/node_modules/c`)).toEqual(true);
Expand Down
5 changes: 5 additions & 0 deletions __tests__/fixtures/install/install-no-bin/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"dependencies": {
"is-pnp": "^1.0.2"
}
}
2 changes: 1 addition & 1 deletion src/package-linker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,7 +444,7 @@ export default class PackageLinker {
possibleExtraneous,
artifactFiles,

ignoreBasenames: [constants.METADATA_FILENAME, constants.TARBALL_FILENAME],
ignoreBasenames: [constants.METADATA_FILENAME, constants.TARBALL_FILENAME, '.bin'],

onStart: (num: number) => {
tick = this.reporter.progress(num);
Expand Down