Increase Windows timeouts and better name Test results #6680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
November 13, 2018 16:38
…others close to default 5 sec.
|
Thanks! |
arcanis
added a commit
that referenced
this pull request
Nov 14, 2018
* Set up CI with Azure Pipelines * Update azure-pipelines.yml * Update azure-pipelines.yml * Update package.json * Adds debug * Tries using bash * Tweaks timeouts * Fixes various things related to the win32 compat * I get the same 22 failed tests with/without the delay. * Fix makeFakeBinary for win32. It needs the ".cmd" extension, otherwise it's ignored. Remove #!/bin/sh and instead add @echo off to clean output Use errorCode 0 so we get output and not a Command failed * Check custom output instead of versions. Running fake binaries there was no way to get local versions of node or yarn. Am I missing something? * Remove quotes from echo (not removed in Windows). Replace ; by /n as the former doesn't actually break statements in Windows batch files. * Some tweaks * Fixes syntax * Fixes tests on Windows * Adds test reporting * Fixes things (?) * Fixes indent * Always run the test result publishing * Fixes yml * Use node scripts to avoid Windows interoperability issues. * Fixes the "must use the same Node as Yarn itself" test * Fixes escaping from within the tests * Removes the accidental .only flag * Fixes a test on Windows * Add support for different drives in Windows. So if code is in D: but temporary folder is in C:, don't try to find a relative path but stay on the absolute one. * No need to getPackageLocation * Add support for environment and arguments by using a custom solution instead of cmd-shim. * Missing escape on path in pnpapi test. * Some cleaning * Runs tests on all three platforms * Fixes write paths * Fixes normalizePath * Disables pkg-tests from CircleCI (moved to Azure) * Increase Windows timeouts and better name Test results (#6680) * Increase timeout in Windows, we're seeing tests failing randomly and others close to default 5 sec. * Distinguish tests published from each job. * Pass name as vmImage is not available * Remove unnecessary detect unfinished tests. * Using strategy var instead of parameter * Use variables instead of strategy * Revert "Disables pkg-tests from CircleCI (moved to Azure)" This reverts commit 8f72462.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests in Windows may randomly take up to 5s, increasing to 10s.
Better name test results with its source job.
@arcanis Can you integrate this in your PR?
Let me know if you see any other blocker.
We're also looking into fastening up these tests,