Skip to content

Simplify writer #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 15, 2023
Merged

Simplify writer #151

merged 3 commits into from
Feb 15, 2023

Conversation

rekby
Copy link
Member

@rekby rekby commented Feb 14, 2023

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Use asyncio.Lock for sync access to structures and notifications

What is the new behavior?

Remove lock and use futures.

@rekby rekby changed the base branch from main to v3 February 14, 2023 12:02
@rekby rekby marked this pull request as ready for review February 14, 2023 13:01
@rekby rekby requested a review from Valeria1235 February 14, 2023 13:01
@rekby rekby enabled auto-merge February 14, 2023 13:05
@rekby rekby merged commit bece3a7 into v3 Feb 15, 2023
@rekby rekby deleted the simplify-writer branch February 15, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify topic writer with use state changed event instead of asyncio.Lock
2 participants