Codec support for writer #198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rekby
force-pushed
the
134-support-codecs-to-writer
branch
3 times, most recently
from
1400ae5 to
dfb2af4
Compare
rekby
force-pushed
the
134-support-codecs-to-writer
branch
from
dfb2af4 to
3902748
Compare
rekby
force-pushed
the
134-support-codecs-to-writer
branch
from
95d007b to
1104d9d
Compare
rekby
commented
Mar 7, 2023
| self._messages_future.extend(messages_future) | ||
|
|
||
| for m in internal_messages: | ||
| self._new_messages.put_nowait(m) | ||
| if self._codec == PublicCodec.RAW: |
There was a problem hiding this comment.
If need encode message - send it to encode loop, else - direct add to send queue.
| encode_waiters = [] | ||
| encoder_function = self._codec_functions[codec] | ||
|
|
||
| for message in messages: |
There was a problem hiding this comment.
start encode messages in parallel
| self._codec_selector_batch_num += 1 | ||
| return codec | ||
|
|
||
| async def _get_available_codecs(self) -> List[PublicCodec]: |
There was a problem hiding this comment.
Get allowed codec from server and intersect it with supported codecs with encoders map.
If server side has no codec restriction - use raw and gzip only (for better compatibility with readers).
Valeria1235
suggested changes
Mar 7, 2023
rekby
force-pushed
the
134-support-codecs-to-writer
branch
from
fe741fa to
ccc6eec
Compare
Valeria1235
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Pull request type
Please check the type of change your PR introduces: