Don't shellescape parts of search patterns #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9
The (incomplete) patterns were shellescape()'d. Even if the full pattern were parsed by s:parseArgs(), it isn't necessary since the user is typing in an argument to a command in the shell in the first place.
Note there is a separate issue in the original code in how s:parseArgs() incorrectly assumes that the first non-option argument is the entire search pattern. Vim's
<f-args>doesn't handle quotes like shell quoting, unfortunately, making this assumption in s:parseArgs() incorrect. I went ahead and opened #11 to track this separate issue.