-
-
Notifications
You must be signed in to change notification settings - Fork 2
feat: Move config fixtures into config
subdirectory.
#35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #35 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 60 60
===========================================
Files 1 1
Lines 91 91
===========================================
Hits 91 91 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Caution Review failedThe pull request is closed. WalkthroughThe changes update the changelog to reflect a new version and enhancement, specifically the relocation of configuration fixtures into a dedicated subdirectory. Correspondingly, all test references to these fixture files in the test suite were updated to use the new directory structure, with no changes to test logic or public interfaces. Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
config
subdirectory.config
subdirectory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
CHANGELOG.md (1)
5-5
: Add author attribution for consistency.
Previous enhancement entries include the author in parentheses. Consider updating to:- Enh #35: Move config fixtures into `config` subdirectory (@terabytesoftw)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
CHANGELOG.md
(1 hunks)tests/ServiceMapTest.php
(18 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
tests/ServiceMapTest.php (1)
src/ServiceMap.php (1)
ServiceMap
(63-468)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: phpunit-compatibility / PHP 8.3-windows-latest
🔇 Additional comments (18)
CHANGELOG.md (1)
3-3
: Version header updated for upcoming release.
The new0.3.0 Under development
entry correctly precedes the dated releases.tests/ServiceMapTest.php (17)
53-53
: Approve updated fixture path for empty-container config.
Reference now includes theconfig
subdirectory as intended.
62-62
: Approve updated path for primary config fixture.
Theconfig.php
fixture is correctly referenced underfixture/config
.
168-168
: Approve updated fixture path for unsupported-components array test.
The path now points tofixture/config/components-unsupported-is-not-array.php
.
182-182
: Approve updated path for unsupported-components ID type test.
The fixture reference includes the newconfig
folder.
203-203
: Approve updated path for config unsupported return type test.
Points tofixture/config/config-unsupported-is-not-array.php
.
217-217
: Approve updated fixture path for invalid container definitions.
Now usesfixture/config/definitions-unsupported-is-not-array.php
.
233-233
: Approve updated path for invalid container type array test.
Referencingfixture/config/config-container-unsupported-type-array-invalid.php
.
247-247
: Approve updated path for invalid singletons array test.
Points tofixture/config/singletons-unsupported-is-not-array.php
.
263-263
: Approve updated path for closure definitions missing return type.
Usesfixture/config/definitions-closure-not-return-type.php
.
277-277
: Approve updated path for unsupported definition ID test.
Updated tofixture/config/definitions-unsupported-id-not-string.php
.
291-291
: Approve updated path for unsupported definition type test.
Referencesfixture/config/definitions-unsupported-type-integer.php
.
319-319
: Approve updated path for unsupported empty-array definition test.
Now atfixture/config/definitions-unsupported-empty-array.php
.
333-333
: Approve updated path for duplicate integer definition test.
Fixture moved tofixture/config/definitions-unsupported-type-integer.php
.
347-347
: Approve updated path for singleton closure missing return type test.
Now underfixture/config/singletons-closure-not-return-type.php
.
361-361
: Approve updated path for singleton ID type test.
Points tofixture/config/singletons-unsupported-id-not-string.php
.
375-375
: Approve updated path for singleton invalid type array test.
Referencesfixture/config/singletons-unsupported-type-array-invalid.php
.
389-389
: Approve updated path for singleton unsupported empty-array test.
Now correctly referencesfixture/config/singletons-unsupported-empty-array.php
.
Summary by CodeRabbit
Documentation
Tests