-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
Fix checkbox
/radio
label rendering when enclosedByLabel
is false
and raise code coverage 100%
in ActiveField::class
.
#20573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix checkbox
/radio
label rendering when enclosedByLabel
is false
and raise code coverage 100%
in ActiveField::class
.
#20573
Conversation
terabytesoftw
commented
Oct 2, 2025
Q | A |
---|---|
Is bugfix? | ✔️ |
New feature? | ❌ |
Breaks BC? | ❌ |
…` and raise code coverage `100%` in `ActiveField::class`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Fixes radio and checkbox label rendering when enclosedByLabel
is false
and achieves 100% code coverage for the ActiveField
class.
- Corrected label handling logic for radio and checkbox inputs when not enclosed by label
- Added comprehensive test coverage for previously untested ActiveField methods and scenarios
- Cleaned up test formatting and improved error message consistency
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
tests/framework/widgets/providers/ActiveFieldProvider.php | New test provider class for hint data validation scenarios |
tests/framework/widgets/ActiveFormTest.php | Removed redundant blank lines from expected HTML output |
tests/framework/widgets/ActiveFieldTest.php | Extensive test additions and improvements covering all ActiveField functionality |
tests/TestCase.php | Added helper method for HTML normalization |
framework/widgets/ActiveField.php | Fixed label rendering logic for radio/checkbox when enclosedByLabel is false |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.