Skip to content

Conversation

terabytesoftw
Copy link
Member

Q A
Is bugfix? ✔️
New feature?
Breaks BC?

@Copilot Copilot AI review requested due to automatic review settings October 2, 2025 12:28
@terabytesoftw terabytesoftw added 22 Yii 2.2 type:bug Bug labels Oct 2, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Fixes radio and checkbox label rendering when enclosedByLabel is false and achieves 100% code coverage for the ActiveField class.

  • Corrected label handling logic for radio and checkbox inputs when not enclosed by label
  • Added comprehensive test coverage for previously untested ActiveField methods and scenarios
  • Cleaned up test formatting and improved error message consistency

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
tests/framework/widgets/providers/ActiveFieldProvider.php New test provider class for hint data validation scenarios
tests/framework/widgets/ActiveFormTest.php Removed redundant blank lines from expected HTML output
tests/framework/widgets/ActiveFieldTest.php Extensive test additions and improvements covering all ActiveField functionality
tests/TestCase.php Added helper method for HTML normalization
framework/widgets/ActiveField.php Fixed label rendering logic for radio/checkbox when enclosedByLabel is false

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Copilot Copilot AI review requested due to automatic review settings October 6, 2025 11:22
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@samdark samdark merged commit e5a8d44 into yiisoft:22.0 Oct 7, 2025
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants