Skip to content

Review AsType tests #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alimanfoo opened this issue Feb 21, 2017 · 3 comments
Closed

Review AsType tests #14

alimanfoo opened this issue Feb 21, 2017 · 3 comments
Milestone

Comments

@alimanfoo
Copy link
Member

Recent PR (#12) has migrated the AsType filter from Zarr. Initial tests look good but it would be good to review prior to next release.

@alimanfoo alimanfoo added this to the 0.1 milestone Feb 21, 2017
@jakirkham
Copy link
Member

Letting you know that I'm cc-ing myself on this issue too. Will also try to have a look at this down the road.

@alimanfoo
Copy link
Member Author

alimanfoo commented Feb 21, 2017 via email

@alimanfoo
Copy link
Member Author

I've taken a look at the tests, seems fine to me, no need for anything further IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants