-
Notifications
You must be signed in to change notification settings - Fork 97
Add AsType codec from Zarr #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks @jakirkham. The |
Thanks for the tips. Went ahead and borrowed from the test suite for Also have incorporated some changes to the representation of |
That's great, thank you. I'm happy to merge this and review the tests afterwards. |
SGTM |
Thanks very much. |
Of course. Thought it was the least I could do after adding it to Zarr while in the midst of this transition. Will try to go back and look at the tests in Zarr as well when I have more time. |
Fixes https://github.com/alimanfoo/zarr/issues/102
Fixes https://github.com/alimanfoo/numcodecs/issues/7
Incorporates https://github.com/alimanfoo/zarr/pull/120
This is very much WIP. In particular, the tests need a bit of help getting cleaned up.Resolved.This adds the AsType codec from Zarr to numcodecs.