Use setup_requires for cpuinfo #130
Conversation
| @@ -22,7 +22,6 @@ matrix: | |||
|
|
|||
| install: | |||
| - pip install -U tox-travis coveralls pip setuptools wheel | |||
| - python setup.py build_ext --inplace | |||
There was a problem hiding this comment.
This isn't actually needed, building will happen via tox.
There was a problem hiding this comment.
Agreed. Think this was causing the build to happen twice before actually.
| have_sse2 = 'sse2' in cpu_info['flags'] | ||
| have_avx2 = 'avx2' in cpu_info['flags'] | ||
| try: | ||
| import cpuinfo |
There was a problem hiding this comment.
Unfortunately this actually won't benefit from setup_requires at this stage as Setuptools hasn't had the opportunity to install py-cpuinfo. To get this to work correctly, we need to add a BuildExtCommand subclass like this one for NumPy and add it to our cmdclasses in setup.
|
On reflection I think I'm going to push back work to avoid vendoring py-cpuinfo to the next release. It's not straightforward to use a |
Use
setup_requiresto obtaincpuinfomodule rather than vendoring it. (Hopefully) supersedes #82.TODO:
tox -e py37passes locallytox -e py27passes locally