Coerce other data to bytes in ensure_text
#213
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To handle array types in `ensure_text` that do not support the Python buffer protocol, it can be handy to coerce them to `bytes` using the `tobytes` method. This way we know we have a `bytes` object that can be decoded. Note: This does incur a copy for some types that may not need this.
Instead of coercing all data to `bytes`, only perform this coercion when the data does not support the Python buffer protocol. IOW when calling `memoryview` on it would raise a `TypeError`. Note: This avoids a copy when the data supports the Python buffer protocol. Otherwise the copy is needed as `codecs.decode` will not know how to work with it, but it can work with `bytes`.
|
To provide a variation of this without copying (unless necessary), have pushed a second commit. This only forces data to |
jakirkham
changed the title
bytes in ensure_textbytes in ensure_text
|
This is ready for review if anyone has a chance to look. 🙂 |
8 tasks
|
Superseded by PR ( #305 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To handle array types in
ensure_textthat do not support the Python buffer protocol, it can be handy to coerce them tobytesusing thetobytesmethod. This way we know we have abytesobject that can be decoded.TODO:
tox -e py38passes locallytox -e py27passes locallytox -e docspasses locally