-
Notifications
You must be signed in to change notification settings - Fork 99
Build + Support Py39 and Various CI Updates #270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
c21e422
Support Py39 in tests
1eb187b
Remove old CI configs
646e7a8
Add or upgrade CI for GH-Actions
5bb37a1
Update doc references to py39
b799296
Remove references to py35
845348a
Fix build docs check on linux ci
84ba313
Test new README badge targets
e790169
Point badges at zarr-developers org
901db02
Update GitHub PR Template
a3cf9ef
More specificity in ci linux on os versions
e87fe02
Upgrade wheel CI to use py39
c7b09dc
Upgrade tox docs test to use py39
85cf454
Update cibuildwheel to support py39
54bb7f3
Add back pypi package classifiers
e33ee5f
Swap wheel builds for ubuntu 18 + 20 for latest
5e133a0
Linux CI install deps instead of dev deps
37655c8
Rename OSX steps + change env setup
0850664
Add Windows CI
fc4293b
Add newline character to ci-linux
b9b03af
Mark pickle backwards compat xfail on windows
58ed3aa
Add link to GH Issue for windows xfail test
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,11 @@ | ||
[Description of PR] | ||
|
||
TODO: | ||
* [ ] Unit tests and/or doctests in docstrings | ||
* [ ] ``tox -e py38`` passes locally | ||
* [ ] Docstrings and API docs for any new/modified user-facing classes and functions | ||
* [ ] Changes documented in docs/release.rst | ||
* [ ] ``tox -e docs`` passes locally | ||
* [ ] AppVeyor and Travis CI passes | ||
* [ ] Test coverage to 100% (Coveralls passes) | ||
|
||
- [ ] Unit tests and/or doctests in docstrings | ||
- [ ] `tox -e py39` passes locally | ||
- [ ] Docstrings and API docs for any new/modified user-facing classes and functions | ||
- [ ] Changes documented in docs/release.rst | ||
- [ ] `tox -e docs` passes locally | ||
- [ ] GitHub Actions CI passes | ||
- [ ] Test coverage to 100% (Coveralls passes) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
name: Linux CI | ||
|
||
on: [push, pull_request] | ||
|
||
jobs: | ||
build: | ||
runs-on: ${{ matrix.os }} | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
python-version: ["3.6", "3.7", "3.8", "3.9"] | ||
os: [ubuntu-18.04, ubuntu-20.04] | ||
|
||
steps: | ||
- name: Checkout source | ||
uses: actions/checkout@v2 | ||
with: | ||
submodules: recursive | ||
|
||
- name: Set up Python | ||
uses: actions/setup-python@v1 | ||
with: | ||
python-version: ${{ matrix.python-version }} | ||
|
||
- name: Install numcodecs | ||
run: | | ||
python -m pip install -U pip -r requirements_test.txt -r requirements.txt | ||
python -m pip install -v -e . | ||
|
||
- name: List installed packages | ||
run: python -m pip list | ||
|
||
- name: Run tests | ||
run: pytest -v --cov=numcodecs --doctest-modules --doctest-glob=*.pyx numcodecs | ||
|
||
- name: Flake8 | ||
run: flake8 numcodecs | ||
|
||
- name: Build Docs | ||
run: | | ||
pip install -r requirements_rtfd.txt | ||
cd docs | ||
sphinx-build -W -b html -d {envtmpdir}/doctrees . {envtmpdir}/html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
name: Windows CI | ||
|
||
on: [push, pull_request] | ||
|
||
jobs: | ||
build: | ||
runs-on: windows-latest | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
python-version: ["3.6", "3.7", "3.8", "3.9"] | ||
|
||
steps: | ||
- name: Checkout source | ||
uses: actions/checkout@v2 | ||
with: | ||
submodules: recursive | ||
|
||
- name: Set up Python | ||
uses: conda-incubator/setup-miniconda@master | ||
with: | ||
channels: conda-forge | ||
python-version: ${{ matrix.python-version }} | ||
env: | ||
ACTIONS_ALLOW_UNSECURE_COMMANDS: true | ||
|
||
- name: Set up env | ||
shell: "bash -l {0}" | ||
run: | | ||
conda create -n env python==${{matrix.python-version}} wheel pip compilers | ||
conda activate env | ||
which pip | ||
pip install -r requirements_test.txt -r requirements.txt | ||
conda env export | ||
|
||
- name: Install numcodecs | ||
shell: "bash -l {0}" | ||
run: | | ||
conda activate env | ||
export CC=clang | ||
python setup.py build | ||
|
||
- name: Run tests | ||
shell: "bash -l {0}" | ||
run: | | ||
conda activate env | ||
pytest -v --pyargs numcodecs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
Cython==0.29.6 | ||
msgpack==0.6.1 | ||
numpy==1.16.2 | ||
Cython==0.29.21 | ||
msgpack==1.0.2 | ||
numpy==1.19.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -322,18 +322,19 @@ def run_setup(with_extensions): | |
python_requires=">=3.6, <4", | ||
packages=["numcodecs", "numcodecs.tests"], | ||
classifiers=[ | ||
'Development Status :: 4 - Beta', | ||
'Intended Audience :: Developers', | ||
'Intended Audience :: Information Technology', | ||
'Intended Audience :: Science/Research', | ||
'License :: OSI Approved :: MIT License', | ||
'Programming Language :: Python', | ||
'Topic :: Software Development :: Libraries :: Python Modules', | ||
'Operating System :: Unix', | ||
'Programming Language :: Python :: 3', | ||
'Programming Language :: Python :: 3.6', | ||
'Programming Language :: Python :: 3.7', | ||
'Programming Language :: Python :: 3.8', | ||
"Development Status :: 4 - Beta", | ||
"Intended Audience :: Developers", | ||
"Intended Audience :: Information Technology", | ||
"Intended Audience :: Science/Research", | ||
"License :: OSI Approved :: MIT License", | ||
"Programming Language :: Python", | ||
"Topic :: Software Development :: Libraries :: Python Modules", | ||
"Operating System :: Unix", | ||
"Programming Language :: Python :: 3", | ||
"Programming Language :: Python :: 3.6", | ||
"Programming Language :: Python :: 3.7", | ||
"Programming Language :: Python :: 3.8", | ||
"Programming Language :: Python :: 3.9", | ||
], | ||
author='Alistair Miles', | ||
author_email='[email protected]', | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.