Fix macOS Python 3.10 #311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is often needed when filling out issues in conda-forge. So just provide this in the CI logs so it is easy to find and share
If `clang` version `12.0.0` is picked up, we encounter issues with TAPI on macOS. For some reason this happens with Python 3.10 and not other Pythons. In any event requiring `12.0.1`+ ensures TAPI support is working correctly, so just apply that constraint when installing `compilers` to avoid issues.
|
cc @joshmoore @rabernat (for vis) |
|
Odd, but 👍 |
|
Yeah I filed issue ( conda-forge/clangdev-feedstock#166 ) about this |
This behaves as exactly equals, which means we don't get patch version updates (like 3.10.2) instead we get (3.10.0). So this relaxes that to allow patch version fixes.
jakirkham
commented
Feb 25, 2022
| conda create -n env python==${{matrix.python-version}} wheel pip compilers 'clang>=12.0.1' | ||
| conda create -n env python=${{matrix.python-version}} wheel pip compilers 'clang>=12.0.1' |
There was a problem hiding this comment.
Having ==s effectively means 3.10.0 instead of 3.10.0+. As we likely don't want to pin the patch version to 0, relaxing that here. May be part of the issue we were seeing as well
|
Was unable to reproduce the issue locally. Have In any event this should unblock CI here. Will see if anything turns up in the upstream issue. |
|
CI looks green ✅ |
This was referenced Feb 25, 2022
|
Merging to fix CI. Hope that is ok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason we pick up
clangversion12.0.0only in the Python 3.10 job, which has problems with TAPI (hence the CI issues we have been seeing). These issues are not present withclangversion12.0.1+ (hence why the other Python jobs work). So here we requireclangversion12.0.1+ when installing compilers to fix CI.Edit: Also included a bit more debug info in CI to aid with issue templates that Conda & conda-forge use
TODO:
tox -e py39passes locallytox -e docspasses locally