Fix intermittent macOS GHA build issues w/AVX2 #482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ideally this specification is not needed to pick up the right compiler on macOS. So try dropping it to see if things still work.
Lately there have been intermittent issues on macOS GHA building with AVX2 support on. So just turn it off. Hopefully this clears those errors.
|
Configuring automerge so this can merge as soon as CI passes. Hopefully that will help us unstick the other fixes Not worrying about a release note since this is just fixing our CI and so would likely be uninteresting to a user |
DimitriPapadopoulos
pushed a commit
to DimitriPapadopoulos/numcodecs
that referenced
this pull request
Aug 10, 2024
* Try dropping `CC` on macOS GHA builds Ideally this specification is not needed to pick up the right compiler on macOS. So try dropping it to see if things still work. * Disable AVX2 on macOS Lately there have been intermittent issues on macOS GHA building with AVX2 support on. So just turn it off. Hopefully this clears those errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lately there have been intermittent build issues on macOS GHA as AVX2 instructions are being used with the build. To fix this, try just turning off AVX2 on macOS GHA builds.
Fixes #473
TODO: