Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a couple of issues relating to the new msgpack codec (codec ID "msgpack2") being introduced in numcodecs version 0.6.0:
encoding
argument topackb
andunpackb
is being deprecated and is generating aPendingDeprecationWarning
. The arguments have been changed as recommended to useraw=False
instead, withraw=True
being available as an option. Two other relevant options,use_bin_type
anduse_single_float
have also been surfaced from msgpack. Resolves msgpack: PendingDeprecationWarning: encoding is deprecated, Use raw=False instead #85.N.B., because default values for some arguments being passed through to msgpack in the newer codec have changed in this PR, the fixture for the "msgpack2" codec has been regenerated. This is OK because the codec has not actually been released yet.
For reference, the initial work to add the new msgpack2 codec was done in PR #77.
TODO:
tox -e py37
passes locallytox -e py27
passes locallytox -e docs
passes locally