-
-
Notifications
You must be signed in to change notification settings - Fork 330
check type of attribute keys #1066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1066 +/- ##
=======================================
Coverage 99.94% 99.94%
=======================================
Files 34 34
Lines 13846 13865 +19
=======================================
+ Hits 13839 13858 +19
Misses 7 7
|
I'm not sure whether we should add a note somewhere in the documentation/docstrings. Other than that, this PR is ready for review. cc: |
@malmans2 : I don't think I can update your branch with the latest origin/main. Could you do so to get all the tests passing? |
Done! Let me know if we should start a deprecation cycle. |
Happy if someone who wants to be adventurous speaks up, but I'd err on the side of the deprecation cycle. |
Sorry for the delay, @malmans2, and thanks for the deprecation cycle. If we're temporarily accepting the stringification, would you be able to workaround your TypeError by explicitly calling |
Thanks, @malmans2! Rolling into 2.13 |
Closes #1037
This PR adds a check that does not allow to use attribute keys other than strings.
TODO: