-
-
Notifications
You must be signed in to change notification settings - Fork 331
Create codeql-analysis.yml #1127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Primary TODO is convert:
to
|
CodeQL fails on multiple occurrences of the issue documented in #906. Should we shut up this warning, if possible at all? |
Have you seen how to do that configuration? If not, perhaps it's time to tackle #906. |
See Dismissing alerts:
It looks like we cannot easily dismiss the alerts from a configuration file or with a comment in the line of code that generates the alert. |
Adds zarr.tests.util.mktemp which can be used from all tests. The NamedTemporaryFile is immediately closed and only the path returned.
Codecov Report
@@ Coverage Diff @@
## main #1127 +/- ##
=======================================
Coverage 99.95% 99.95%
=======================================
Files 36 36
Lines 14112 14117 +5
=======================================
+ Hits 14105 14110 +5
Misses 7 7
|
@DimitriPapadopoulos, that seems to have done it. |
Green after a restart. Let's merge and see if it helps or hinders. (We can always disable) |
see:
[Description of PR]
TODO: