Skip to content

2.13.1: generate fixture/meta in conda tests #1143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 26, 2022

Conversation

joshmoore
Copy link
Member

Following the pattern from #824, this generates the
fixture test if it does not exist so that tests will
pass on conda-forge.

see: conda-forge/zarr-feedstock#65

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

Following the pattern from zarr-developers#824, this generates the
fixture test if it does not exist so that tests will
pass on conda-forge.

see: conda-forge/zarr-feedstock#65
@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Merging #1143 (37c1f9a) into main (bc13b7f) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1143      +/-   ##
==========================================
- Coverage   99.95%   99.95%   -0.01%     
==========================================
  Files          36       36              
  Lines       14115    14112       -3     
==========================================
- Hits        14108    14105       -3     
  Misses          7        7              
Impacted Files Coverage Δ
zarr/tests/test_storage.py 100.00% <100.00%> (ø)
zarr/util.py 100.00% <0.00%> (ø)
zarr/indexing.py 100.00% <0.00%> (ø)
zarr/tests/test_hierarchy.py 100.00% <0.00%> (ø)

@joshmoore joshmoore merged commit 814017d into zarr-developers:main Sep 26, 2022
@joshmoore joshmoore deleted the 2_13_1 branch September 26, 2022 12:31
@joshmoore
Copy link
Member Author

Argh Still failing ... conda-forge/zarr-feedstock#66

joshmoore added a commit to joshmoore/zarr-python that referenced this pull request Sep 27, 2022
See description in zarr-developers#1143
Testing locally, however, does not suffice. In this case, the relative path
in the test worked for me, but doesn't work on conda-forge. The only reliable
way to be sure is to run `./build-locally.py` in the zarr-feedstock
**against pre-tagged code**.
joshmoore added a commit that referenced this pull request Sep 27, 2022
See description in #1143
Testing locally, however, does not suffice. In this case, the relative path
in the test worked for me, but doesn't work on conda-forge. The only reliable
way to be sure is to run `./build-locally.py` in the zarr-feedstock
**against pre-tagged code**.
enthusiastdev121 added a commit to enthusiastdev121/zarr-python that referenced this pull request Aug 19, 2024
See description in zarr-developers/zarr-python#1143
Testing locally, however, does not suffice. In this case, the relative path
in the test worked for me, but doesn't work on conda-forge. The only reliable
way to be sure is to run `./build-locally.py` in the zarr-feedstock
**against pre-tagged code**.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant