Skip to content

fix #1167: Added installation.rst to docs #1170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 11, 2022

Conversation

DON-BRAN
Copy link
Contributor

[Description of PR]

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@joshmoore
Copy link
Member

Looking at https://zarr--1170.org.readthedocs.build/en/1170/index.html, I'd suggest removing from the main page since now it's listed twice.

@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Merging #1170 (e013e1a) into main (53357f7) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1170      +/-   ##
==========================================
- Coverage   99.95%   99.95%   -0.01%     
==========================================
  Files          36       36              
  Lines       14143    14142       -1     
==========================================
- Hits        14136    14135       -1     
  Misses          7        7              
Impacted Files Coverage Δ
zarr/util.py 100.00% <0.00%> (ø)

@joshmoore
Copy link
Member

Thanks again, @DON-BRAN. 👍

@joshmoore joshmoore merged commit 6ef11d3 into zarr-developers:main Oct 11, 2022
@DON-BRAN DON-BRAN deleted the add_installation_doc branch October 21, 2022 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants