Fix linting errors #1226
Merged
Fix linting errors #1226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids having to check the version twice: once in the "in [2,3]" and also in the if/elif statement. It also fixes linting error of normalize_store being possibly unbound.
caviere
force-pushed
the
fix-linting-errors
branch
from
426d3c5 to
d681659
Compare
Codecov Report
@@ Coverage Diff @@
## main #1226 +/- ##
========================================
Coverage 99.99% 99.99%
========================================
Files 33 35 +2
Lines 13744 14137 +393
========================================
+ Hits 13743 14136 +393
Misses 1 1
|
|
I am using pyright currently |
|
Many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix possible unbound variable error
Avoid extra zarr version check
Add Optional typing to indicate value might be None