Support LZMA on Python 2 via backports.lzma #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Appears to be working. |
|
Happy to include if would be helpful to you, but I will try to find some time to do #74, which I definitely want to do before the next Zarr release. |
|
Yeah, I've been doing development builds of Zarr for my uses. So having this included already instead of having to patch it in would be preferable. |
|
Thanks. |
alimanfoo
added
enhancement
This was referenced Feb 28, 2022
This was referenced Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport(?) of PR ( https://github.com/alimanfoo/numcodecs/pull/13 ).
Tries to use
backports.lzmaas a fallback iflzmais not found (e.g. Python 2). Adds testing for it on Travis CI.