Unpin setuptools requirements #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As all of these are now requirements of `setuptools` instead of being vendored as they were before, pinning them to anything other than the latest version has adverse consequences. So this drops all of these pins.
|
FWIW if these are all requirements of setuptools then we could remove them completely from requirements_dev.txt. Happy either way. |
|
We may want to pin them in the future so we can have some reproducibility in our lives again. Leaving them present, but unpinned can serve as a reminder. That said, if you feel strongly about dropping them, I'm willing to drop them entirely. |
|
Good point, merged as-is. |
alimanfoo
added
maintenance
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/alimanfoo/zarr/issues/125
As all of these are now requirements of
setuptoolsinstead of being vendored as they were before, pinning them to anything other than the latest version has adverse consequences. So this drops all of these pins. More details about the problem and possible fixes in issue ( pypa/pip#4264 ).