Test and fix for #143 index with numpy integer item #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakirkham
reviewed
Apr 26, 2017
zarr/compat.py
Outdated
| reduce = reduce | ||
|
|
||
| else: | ||
|
|
||
| text_type = str | ||
| binary_type = bytes | ||
| integer_types = int, | ||
| integer_types = (int,) + numpy_integer_types |
There was a problem hiding this comment.
Were we using this for conversion or type checking? If the latter, numbers.Integral works well for type checking all integers including NumPy typed ones.
There was a problem hiding this comment.
Ah OK, didn't know about that. Yes it's for type checking.
|
Updated to use numbers.Integral. Merging soon. |
|
LGTM. Merge away. :) |
|
Thanks :) |
alimanfoo
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #143.