Skip to content

Single startswith() call instead of multiple ones #1556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 7, 2023
Merged

Single startswith() call instead of multiple ones #1556

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b0ef6c3
Single startswith() call instead of multiple ones
DimitriPapadopoulos Oct 31, 2023
34d6f26
Merge branch 'main' into startswith
d-v-b Oct 31, 2023
6e7c00d
Merge branch 'main' into startswith
jhamman Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions zarr/_storage/store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,9 +221,8 @@ def _validate_key(self, key: str):
)

if (
not key.startswith("data/")
and (not key.startswith("meta/"))
and (not key == "zarr.json")
not key.startswith(("data/", "meta/"))
and key != "zarr.json"
# TODO: Possibly allow key == ".zmetadata" too if we write a
# consolidated metadata spec corresponding to this?
):
Expand Down