Remove old v3 #1742
Merged
Remove old v3 #1742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@d-v-b - do you think this code will ever be released? Since your target is the v3 branch, I think its reasonable to just remove these sections now. |
* refactor(v3): Using appropriate types * fix(v3): Typing fixes + minor code fixes * fix(v3): _sync_iter works with coroutines * docs(v3/store/core.py): clearer comment * fix(metadata.py): Use Any outside TYPE_CHECKING for Pydantic * fix(zarr/v3): correct zarr format + remove unused method * fix(v3/store/core.py): Potential suggestion on handling str store_like * refactor(zarr/v3): Add more typing * ci(.pre-commit-config.yaml): zarr v3 mypy checks turned on in pre-commit
…elopers#1728) * Specify v3 hatch envs using GitHub actions matrix * Update .github/workflows/test-v3.yml Co-authored-by: Joe Hamman <[email protected]> * Update .github/workflows/test-v3.yml Co-authored-by: Joe Hamman <[email protected]> * test on 3.12 too * no 3.12 --------- Co-authored-by: Joe Hamman <[email protected]> Co-authored-by: Joe Hamman <[email protected]>
* black -> ruff + cleanup * format * Preserve git blame * pre-commit fix
…ntributing.rst (zarr-developers#1643) Co-authored-by: Joe Hamman <[email protected]>
|
This is ready for review. To summarize the changes, because it's a lot of LOC:
|
jhamman
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plan here is to remove the old implementation of Zarr v3 (the old version 3). I think fully removing the old v3 stuff would be a minor accelerator for the new V3 effort because it removes the possibility of confusing the old v3 with the new v3 in the codebase, and it reduces the LOC of the codebase which makes the old code easier to read / test.
At the moment, I have just slathered deprecation warnings atop the old V3 routines, which lets my IDE (vscode) visually indicate which stuff is using those old routines. If we feel OK about this effort, I would go ahead and prune the old v3 classes entirely, and remove the WIP tag from this PR.
closes #1771