Skip to content

Conversation

dstansby
Copy link
Contributor

@dstansby dstansby commented Apr 11, 2024

Some of the easier fixes for some of the untyped definitions.

@pep8speaks
Copy link

pep8speaks commented Apr 11, 2024

Hello @dstansby! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 356:36: E203 whitespace before ':'

Comment last updated at 2024-04-14 08:26:13 UTC

@dstansby dstansby force-pushed the v3-fix-untyped-defs branch from a160dc8 to c27b0a8 Compare April 14, 2024 08:08
@dstansby dstansby force-pushed the v3-fix-untyped-defs branch from c1f903a to 1b63c79 Compare April 14, 2024 08:24
@dstansby dstansby mentioned this pull request Apr 14, 2024
16 tasks
@dstansby dstansby marked this pull request as ready for review April 14, 2024 10:11
@jhamman jhamman added the V3 label Apr 22, 2024
@jhamman jhamman added this to the 3.0.0.alpha milestone Apr 22, 2024
@jhamman
Copy link
Member

jhamman commented Apr 24, 2024

@dstansby -- first, thanks for the continued effort here. With #1809 in, you have a few conflicts to resolve. I also think you can stop making changes to everything in the v2 directory going forward. We plan to remove that code path once the v3 effort wraps up.

@dstansby
Copy link
Contributor Author

Good to know! I think all the changes here are now redundant, so I'll close.

@dstansby dstansby closed this Apr 24, 2024
@jhamman jhamman added the types label Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants